feat(raiko): put the tasks that cannot run in parallel into pending list #358
+71
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smtmfft
commented
Sep 5, 2024
smtmfft
commented
Signed-off-by: smtmfft <smtm@taiko.xyz>
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
petarvujovic98
requested changes
Sep 9, 2024
Co-authored-by: Petar Vujović <petarvujovic98@gmail.com>
Co-authored-by: Petar Vujović <petarvujovic98@gmail.com>
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
johntaiko
reviewed
Sep 9, 2024
| opts, | ||
| chain_specs, | ||
| running_tasks, | ||
| pending_tasks, | ||
| receiver, |
There was a problem hiding this comment.
In Rust, we usually use rx and tx to replace receiver and sender.
| @@ -146,6 +146,7 @@ pub struct ProverState { | |||
| pub enum Message { | |||
| Cancel(TaskDescriptor), | |||
| Task(ProofRequest), | |||
| TaskComplete(ProofRequest), | |||
There was a problem hiding this comment.
We can use oneshot channel to notify the watcher the result of tasks
There was a problem hiding this comment.
you mean notify one-shot channel & let it send task in??
smtmfft
temporarily deployed
to
test-environment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.