Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core,host): initial aggregation API #375
base: proof-aggregation
Are you sure you want to change the base?
feat(core,host): initial aggregation API #375
Changes from 9 commits
83d538b
df758fa
ccb2fb3
9b829db
2ccac77
247ffee
2e6f7d8
29e6fb1
a887cc6
c2b0db5
5d29f78
8a3947b
7276c7b
83df208
f4f818d
00e2374
728cb3a
16e4abc
fa6fe88
1aaec18
789a599
0358a26
a033011
9da8834
bdcb5f3
334d93f
e1d79ff
e34567f
d14774d
62c29a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added this in the design document, but doesn't it make more sense for this to just take a list of proofs?
https://www.notion.so/Proof-aggregation-API-dbd4fcec46d049b78132072555386a40?d=6052f3ea6244452e98add34ec292cd1a&pvs=4#05a93b35e0e941c7b94ef8bed5be6112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cp the notion reply and let's discuss it here.
I think the streaming style is what you want, but perhaps I mis-understand your optimistic mode, correct me if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Brechtpd It does make more sense to keep it as a separate route to only aggregate existing proofs, but as @smtmfft and I talked about, for the initial version it is easier for the client to test it with a similar request style which proves all the requested blocks.
I will create a aggregate-only endpoint to handle the optimal scenario, but for now just allowing a quicker path to integration unless we want to go with the more optimal approach right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are other considerations than of course okay with me with the current approach, just trying to avoid any additional work if going from the current block indices to the proofs one would be significantly different and so some code being written now would be deprecated quite quickly.