This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(prover): fix / upgrade integration test #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mask-pp
changed the title
mask-pp
changed the title
mask-pp
requested review from
davidtaikocha and
cyberhorsey
and removed request for
davidtaikocha
Looks like the github action is failed (but don't know why it says successful in this PR page...) ref: https://github.com/taikoxyz/taiko-client/actions/runs/7486090636/job/20375748869 |
Because |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 58.19% 58.15% -0.05%
==========================================
Files 44 44
Lines 5523 5532 +9
==========================================
+ Hits 3214 3217 +3
- Misses 1991 1994 +3
- Partials 318 321 +3 ☔ View full report in Codecov by Sentry. |
davidtaikocha
changed the title
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: David <david@taiko.xyz>
davidtaikocha
approved these changes
Jan 12, 2024
davidtaikocha
added a commit
that referenced
this pull request
Jan 12, 2024
Co-authored-by: David <david@taiko.xyz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split integration-test into 3 steps:
common.Hex2Byteswithcommon.FromHex, so that we don't need to consider the "0x" prefix.