Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): catch geth withdrawals root hash up to latest protocol changes #76

Merged
merged 3 commits into from
May 19, 2023

Conversation

cyberhorsey
Copy link

@cyberhorsey cyberhorsey commented May 18, 2023

paired taiko-mono PR: taikoxyz/taiko-mono#13781

This PR cleans up the implementation to be more specific about being big endian rather than manipulating byte slice, and adds an identical-to-solidity-test more complicated test case to ensure hash is identical.

@davidtaikocha davidtaikocha merged commit 5493680 into taiko May 19, 2023
@davidtaikocha davidtaikocha deleted the hash_protocol_change branch May 19, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants