feat(protocol): Add setter to IAddressManager of AddressResolver (#13799

) Co-authored-by: adaki2004 <adaki2004@users.noreply.github.com> Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
taikoxyz · May 23, 2023 · 34de89c · 34de89c
1 parent 8aa0940
commit 34de89c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/packages/protocol/contracts/common/AddressResolver.sol b/packages/protocol/contracts/common/AddressResolver.sol
@@ -29,6 +29,8 @@ abstract contract AddressResolver {
         _;
     }
 
+    event AddressManagerChanged(address addressManager);
+
     /**
      * Resolves a name to an address on the current chain.
      *

diff --git a/packages/protocol/contracts/common/EssentialContract.sol b/packages/protocol/contracts/common/EssentialContract.sol
@@ -6,6 +6,7 @@
 
 pragma solidity ^0.8.18;
 
+import {IAddressManager} from "./AddressManager.sol";
 import {OwnableUpgradeable} from "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol";
 import {ReentrancyGuardUpgradeable} from
     "@openzeppelin/contracts-upgradeable/security/ReentrancyGuardUpgradeable.sol";
@@ -25,4 +26,16 @@ abstract contract EssentialContract is
         OwnableUpgradeable.__Ownable_init();
         AddressResolver._init(_addressManager);
     }
+
+    /**
+     * Sets a new AddressManager's address.
+     *
+     * @param newAddressManager New address manager contract address
+     */
+    function setAddressManager(address newAddressManager) external onlyOwner {
+        if (newAddressManager == address(0)) revert RESOLVER_INVALID_ADDR();
+        _addressManager = IAddressManager(newAddressManager);
+
+        emit IAddressManagerChanged(address(this), newAddressManager);
+    }
 }
diff --git a/...s/website/pages/docs/reference/contract-documentation/common/AddressResolver.md b/...s/website/pages/docs/reference/contract-documentation/common/AddressResolver.md
@@ -37,6 +37,12 @@ error RESOLVER_ZERO_ADDR(uint256 chainId, bytes32 name)
 modifier onlyFromNamed(bytes32 name)
 ```
 
+### IAddressManagerChanged
+
+```solidity
+event IAddressManagerChanged(address changedOn, address newAddress)
+```
+
 ### resolve
 
 ```solidity
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,6 +29,8 @@ abstract contract AddressResolver { @@
             _;
         }
+        event AddressManagerChanged(address addressManager);
         /**
          * Resolves a name to an address on the current chain.
          *
@@ Expand Down @@