fix(bridge-ui): fix relayer #13548
Merged
fix(bridge-ui): fix relayer #13548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
requested review from
jscriptcoder,
shadab-taiko,
adaki2004,
dionysuzx and
dantaik
Codecov Report
@@ Coverage Diff @@
## main #13548 +/- ##
=======================================
Coverage 36.13% 36.13%
=======================================
Files 124 124
Lines 3778 3778
Branches 502 502
=======================================
Hits 1365 1365
Misses 2321 2321
Partials 92 92
*This pull request uses carry forward flags. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jscriptcoder
previously approved these changes
Apr 6, 2023
dionysuzx
previously approved these changes
Apr 6, 2023
jscriptcoder
approved these changes
Apr 6, 2023
dionysuzx
approved these changes
Apr 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were introducedin the bridge Ui to change all the
stringvalues on a message tonumbe, without any concern for integer overflow. This breaks the Transaction list, and renders it completely unusable.This reverts those changes.