Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): fix relayer #13548

Merged
merged 3 commits into from
Apr 6, 2023
Merged

fix(bridge-ui): fix relayer #13548

merged 3 commits into from
Apr 6, 2023

Conversation

cyberhorsey
Copy link
Contributor

Changes were introducedin the bridge Ui to change all the string values on a message to numbe, without any concern for integer overflow. This breaks the Transaction list, and renders it completely unusable.

This reverts those changes.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #13548 (1884151) into main (3944ca8) will not change coverage.
The diff coverage is n/a.

❗ Current head 1884151 differs from pull request most recent head 2141ca8. Consider uploading reports for the commit 2141ca8 to get more accurate results

@@           Coverage Diff           @@
##             main   #13548   +/-   ##
=======================================
  Coverage   36.13%   36.13%           
=======================================
  Files         124      124           
  Lines        3778     3778           
  Branches      502      502           
=======================================
  Hits         1365     1365           
  Misses       2321     2321           
  Partials       92       92           
Flag Coverage Δ *Carryforward flag
bridge-ui 94.20% <ø> (ø)
eventindexer ∅ <ø> (∅) Carriedforward from 8cd5916
protocol 0.00% <ø> (ø) Carriedforward from 8cd5916
relayer 62.53% <ø> (ø) Carriedforward from 8cd5916
ui 100.00% <ø> (ø) Carriedforward from 8cd5916

*This pull request uses carry forward flags. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jscriptcoder
jscriptcoder previously approved these changes Apr 6, 2023
d1onys1us
d1onys1us previously approved these changes Apr 6, 2023
@cyberhorsey cyberhorsey added this pull request to the merge queue Apr 6, 2023
Merged via the queue into main with commit 5f60fd7 Apr 6, 2023
@cyberhorsey cyberhorsey deleted the relayer_api_fix_bridge_ui branch April 6, 2023 00:51
@github-actions github-actions bot mentioned this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants