Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): automatically publish latest blog posts to website #13175

Closed
wants to merge 19 commits into from

Conversation

Jaapiehetaapie
Copy link
Contributor

This only fetches the posts at buildtime

@dantaik
Copy link
Contributor

dantaik commented Feb 19, 2023

This is fine for now, but assuming this repository is stable enough and there is no requirement redeploy, then this solution will not work. I still prefer the dynamic loading approach.

3 similar comments
@dantaik
Copy link
Contributor

dantaik commented Feb 19, 2023

This is fine for now, but assuming this repository is stable enough and there is no requirement redeploy, then this solution will not work. I still prefer the dynamic loading approach.

@dantaik
Copy link
Contributor

dantaik commented Feb 19, 2023

This is fine for now, but assuming this repository is stable enough and there is no requirement redeploy, then this solution will not work. I still prefer the dynamic loading approach.

@dantaik
Copy link
Contributor

dantaik commented Feb 19, 2023

This is fine for now, but assuming this repository is stable enough and there is no requirement redeploy, then this solution will not work. I still prefer the dynamic loading approach.

@dantaik
Copy link
Contributor

dantaik commented Feb 19, 2023

This only fetches the posts at buildtime

This is fine for now, but assuming this repository is stable enough and there is no requirement redeploy, then this solution will not work. I still prefer the dynamic loading approach.

@Jaapiehetaapie
Copy link
Contributor Author

#13169 (comment)
It was mentioned here that fetching at build time would be the best option.

@dantaik
Copy link
Contributor

dantaik commented Feb 20, 2023

#13169 (comment) It was mentioned here that fetching at build time would be the best option.

I see it differently.

BTW, have we already merged a PR of yours that automatically fetch the data in real time? It is in production, isn't it?

@wolfderechter
Copy link
Contributor

BTW, have we already merged a PR of yours that automatically fetch the data in real time? It is in production, isn't it?

That PR was reverted with #13169 because of some issues

@Jaapiehetaapie
Copy link
Contributor Author

I think this may be a good solution. But I think it's good to extract the 'on schedule' to a new workflow file and maybe it's needed to add some secret code to the api, otherwise everyone can call it.

@Jaapiehetaapie
Copy link
Contributor Author

If using node it is needed to commit the changes to the repository. So I think it's better to go with the API way. We could also setup an vervel cron job, but I think it's better to have everything in GitHub actions. Thoughts?

This reverts commit fdd75ff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants