feat(protocol): add unit tests for cooldown period and oracle overriding #13691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overwrite same fk
dantaik
changed the title
dantaik
reviewed
May 2, 2023
| vm.warp(block.timestamp + 1 seconds); | ||
| verifyBlock(Carol, 1); | ||
|
|
||
| // Check if shortly after proving (+verify) the ast verify is not the same anymore |
There was a problem hiding this comment.
Suggested change
| // Check if shortly after proving (+verify) the ast verify is not the same anymore | |
| // Check if shortly after proving (+verify) the last verify is not the same anymore |
dantaik
reviewed
May 2, 2023
| @@ -230,6 +231,69 @@ contract TaikoL1OracleTest is TaikoL1TestBase { | |||
| } | |||
| } | |||
|
|
|||
| function testOracleProverCannotOverwriteIfSameProof() external { | |||
There was a problem hiding this comment.
Not sure you have run pnpm lint:sol, please do it before you commit.
dantaik
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for code described here:
#13686