Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): fix proof #13748

Merged
merged 3 commits into from
May 12, 2023
Merged

fix(bridge-ui): fix proof #13748

merged 3 commits into from
May 12, 2023

Conversation

jscriptcoder
Copy link
Contributor

We no longer use blockHeader in our SignalProof. Fixing the encoded proof:

    // Encode the SignalProof struct:
    // struct SignalProof {
    //   uint256 height;
    //   bytes proof;
    // }
    const signalProof = ethers.utils.defaultAbiCoder.encode(
      ['tuple(uint256 height, bytes proof)'],
      [{ height: blockHeight, proof: encodedProof }],
    );

@jscriptcoder jscriptcoder changed the title fix(bridge-iu): fix proof fix(bridge-ui): fix proof May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #13748 (eaedd68) into main (e3746ee) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13748      +/-   ##
==========================================
- Coverage   44.98%   44.90%   -0.08%     
==========================================
  Files         130      130              
  Lines        3519     3514       -5     
  Branches      363      361       -2     
==========================================
- Hits         1583     1578       -5     
  Misses       1835     1835              
  Partials      101      101              
Flag Coverage Δ *Carryforward flag
bridge-ui 95.96% <100.00%> (-0.05%) ⬇️
eventindexer 82.08% <ø> (ø) Carriedforward from e3746ee
protocol 0.00% <ø> (ø) Carriedforward from e3746ee
relayer 62.53% <ø> (ø) Carriedforward from e3746ee
ui 100.00% <ø> (ø) Carriedforward from e3746ee

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/proof/ProofService.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey added this pull request to the merge queue May 12, 2023
Merged via the queue into main with commit 497d7ab May 12, 2023
@cyberhorsey cyberhorsey deleted the fix_proof branch May 12, 2023 22:28
@github-actions github-actions bot mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants