-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eventindexer): add stats tracking #13810
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated abigen for relayer and eventindexer, abi updates for status page
Codecov Report
@@ Coverage Diff @@
## main #13810 +/- ##
==========================================
+ Coverage 47.24% 47.41% +0.17%
==========================================
Files 131 133 +2
Lines 3357 3406 +49
Branches 310 310
==========================================
+ Hits 1586 1615 +29
- Misses 1668 1682 +14
- Partials 103 109 +6
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
requested review from
RogerLamTd,
davidtaikocha,
jscriptcoder and
dantaik
May 24, 2023 22:32
davidtaikocha
previously approved these changes
May 25, 2023
davidtaikocha
approved these changes
May 25, 2023
RogerLamTd
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR now tracks blockVerified events, and uses the proofTime and proofReward arguments to maintain an average, and sets us up to calculate other stats we want in the future as well. It exposes them via a /stats endpoint for the status page.
this also updates the status page with the new ABI.
note: this PR relies on code that has not been deployed to alpha-3, Dani's blockVerified event reward and fee changes. so we cant deploy it until we deploy those updates.