Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): add quite a few TODOs for Dani #14172

Merged
merged 2 commits into from
Jul 16, 2023
Merged

refactor(protocol): add quite a few TODOs for Dani #14172

merged 2 commits into from
Jul 16, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jul 14, 2023

No description provided.

@dantaik dantaik requested a review from adaki2004 July 14, 2023 17:45
@adaki2004
Copy link
Contributor

Thanks for the feedback Daniel, was all valid.

One point which did not require any action is:
// TODO(dani): query symbol, and name
ERC1155 differs from ERC721, its’ standard interface has only URI, no name and symbol.

@adaki2004 adaki2004 marked this pull request as ready for review July 16, 2023 10:53
@adaki2004 adaki2004 merged commit 249fb7d into ERC721_bridging Jul 16, 2023
@adaki2004 adaki2004 deleted the improve_nft_vaults_4 branch July 16, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @adaki2004 @dong77