refactor(protocol): remove gasUsed and parentGasUsed

[dantaik]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
bridge-ui-v2	⬜️ Ignored (Inspect)	Visit Preview		Aug 25, 2023 4:23am

[cyberhorsey]

I am out of the loop, why are we removing these?

[dantaik]

I am out of the loop, why are we removing these?

Previously proving fees are calculated based on gas used * fee per gas, now proving fee is decided off-chain, so gas used is no longer used on chain.

[cyberhorsey]

I am out of the loop, why are we removing these?

Previously proving fees are calculated based on gas used * fee per gas, now proving fee is decided off-chain, so gas used is no longer used on chain.

Sounds good, in the client is it no longer necessary to use parentGasUsed when checking if a proof is valid (ie: we currently do:

       // its valid 
	if parent.GasUsed == parentGasUsed && parent.Hash() == parentHash && blockHash == block.Hash() {
		return true, nil
	}

i can remove all parentGasUsed checks here, or we should keep them still offchain?

[Brechtpd]

I am out of the loop, why are we removing these?

Previously proving fees are calculated based on gas used * fee per gas, now proving fee is decided off-chain, so gas used is no longer used on chain.

Sounds good, in the client is it no longer necessary to use parentGasUsed when checking if a proof is valid (ie: we currently do:

       // its valid 
	if parent.GasUsed == parentGasUsed && parent.Hash() == parentHash && blockHash == block.Hash() {
		return true, nil
	}

i can remove all parentGasUsed checks here, or we should keep them still offchain?

You can remove them.