Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui-v2): update InsufficientFunds dialog in mobile view #14753

Closed
wants to merge 2 commits into from

Conversation

xiaodino
Copy link
Contributor

Before
Screen Shot 2023-09-19 at 11 02 12 PM

After
Screen Shot 2023-09-19 at 11 48 23 PM

Screen Shot 2023-09-19 at 11 48 45 PM

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 7:46am
bridge-ui-v2-internal ✅ Ready (Inspect) Visit Preview Sep 20, 2023 7:46am

@@ -65,7 +65,7 @@
{/if}

<div class="sm:w-1/4 md:w-1/5 py-2 flex flex-col justify-center">
<Status bridgeTx={item} />
<Status bridgeTx={item} isDesktopOrLarger={isDesktopOrLarger} isMobileDetailsDialog={false}/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are already passing isDesktopOrLarger (should not be passed as prop imho) why do we pass the isMobileDetailsDialog as well?

If isDesktopOrLarger is true isMobileDetailsDialog will always be false.

I think this needs to done differently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying a different approach.

@@ -65,7 +65,7 @@
{/if}

<div class="sm:w-1/4 md:w-1/5 py-2 flex flex-col justify-center">
<Status bridgeTx={item} isDesktopOrLarger={isDesktopOrLarger} isMobileDetailsDialog={false}/>
<Status bridgeTx={item} isFromMobileDetailsDialog={false}/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A component should be agnostic to where it is used, so if you pass properties they should not be required to be set to false like this. You can do that logic inside the component itself.

Generally, we need to rework the way we claim on mobile, it opens the dialog and then instantly tries to claim. That is not how it should work.
Maybe just close this PR, as this is a hacky workaround instead of a proper fix for the underlying problem. I will work on it.

@KorbinianK
Copy link
Contributor

KorbinianK commented Sep 20, 2023

Done in #14759

@KorbinianK KorbinianK closed this Sep 20, 2023
@dantaik dantaik deleted the xiaodino/fix-model-status-1 branch September 25, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants