-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge-ui-v2): update InsufficientFunds dialog in mobile view #14753
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -65,7 +65,7 @@ | |||
{/if} | |||
|
|||
<div class="sm:w-1/4 md:w-1/5 py-2 flex flex-col justify-center"> | |||
<Status bridgeTx={item} /> | |||
<Status bridgeTx={item} isDesktopOrLarger={isDesktopOrLarger} isMobileDetailsDialog={false}/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are already passing isDesktopOrLarger
(should not be passed as prop imho) why do we pass the isMobileDetailsDialog
as well?
If isDesktopOrLarger
is true
isMobileDetailsDialog
will always be false
.
I think this needs to done differently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying a different approach.
@@ -65,7 +65,7 @@ | |||
{/if} | |||
|
|||
<div class="sm:w-1/4 md:w-1/5 py-2 flex flex-col justify-center"> | |||
<Status bridgeTx={item} isDesktopOrLarger={isDesktopOrLarger} isMobileDetailsDialog={false}/> | |||
<Status bridgeTx={item} isFromMobileDetailsDialog={false}/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A component should be agnostic to where it is used, so if you pass properties they should not be required to be set to false like this. You can do that logic inside the component itself.
Generally, we need to rework the way we claim on mobile, it opens the dialog and then instantly tries to claim. That is not how it should work.
Maybe just close this PR, as this is a hacky workaround instead of a proper fix for the underlying problem. I will work on it.
Done in #14759 |
Before
After