-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(supplementary-contracts): add TokenUnlocking #16830
Conversation
feat(supplementary-contracts): add TokenUnlocking
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
I would also say generally option 2 makes the most sense, because if people have to pay upfront it's not really usable as an alternative way for income:
I think option 1 is interesting for higher risk/higher reward, but doesn't seem like a great fit for normal employees unless the price/amount of the tokens is low enough. |
The token grant agreement mandates option 1 (upfront payment). The token purchase action must be completed with full payment before tokens will be deposited to the smart contracts. From a legal perspective, if labs deposits token without receiving a payment, who legally owns those token then? To ensure people are not losing money, we should only charge grantees the cost after they have sold the token... |
1553072
to
9ddcf8e
Compare
Added the first version of
TokenUnlocking
contract.Pretty simple, but there are some
todo
, please search for that text.So my question (i also asked in discord DM):
Base situation, per those quarterly/half-yearly unvesting and it’s excersise :
But the question here is: Is Bob really paying OR he acknowledges that he wants to get those tokens and he will pay once he will withdraw ?
costToWithdraw
andcostToken
variables, because the purchase notice has to be paid before the vested amount is deposited into the contract. (If so, i have to remove them and contract gets simpler).OR
And in the situation above steps nr. 1 & 2 is just a "YES-I-ACKNOWEDGE-I-WANT-MY-TOKENS", but Bob does not have to pay immediately (just at withdrawal).
Somewhat i'm kind of in favor of the second version, because of the following reason: