Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taikoon): migrate Taikoon NFT smart contracts here #16849

Merged
merged 26 commits into from
Apr 26, 2024

Conversation

bearni95
Copy link
Contributor

@bearni95 bearni95 commented Apr 25, 2024

  • Copy the code over
  • Make the tests run
  • Make the scripts run

@bearni95 bearni95 changed the title chore(taikoons): contract migration chore(taikoon): contract migration Apr 25, 2024
Copy link

openzeppelin-code bot commented Apr 25, 2024

feat(taikoon): migrate Taikoon NFT smart contracts here

Generated at commit: 7e0753e42e75fdc27087877fe0db7141ac7b99b2

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
5
41
50
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

.gitmodules Outdated Show resolved Hide resolved
@dantaik dantaik changed the title chore(taikoon): contract migration feat(taikoon): migrate Taikoon NFT smart contracts here Apr 25, 2024
@dantaik dantaik requested a review from adaki2004 April 25, 2024 14:17
@dantaik
Copy link
Contributor

dantaik commented Apr 25, 2024

Screenshot 2024-04-25 at 22 18 12

@adaki2004 do you see these errors after "pnpm install && pnpm test"?

@adaki2004
Copy link
Contributor

pnpm install

Screenshot 2024-04-25 at 22 18 12

@adaki2004 do you see these errors after "pnpm install && pnpm test"?

I can see the same error when i run forge test (after pnpm install).

(I cannot run tho pnpm install && pnpm test the exact smae way you copied here, because it throws some other shit. But when i run the forge test, it shows me these errors, yes).

@dantaik
Copy link
Contributor

dantaik commented Apr 26, 2024

The issue is with the openzeppelin-foundry-upgrades library. Maybe it's not compatible with the compiler or OZ libraries we use.
Please remove it and use proxy = address(new ERC1967Proxy(new SomeContract(), data)); directly.

@dantaik dantaik added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit b392911 Apr 26, 2024
5 checks passed
@dantaik dantaik deleted the taikoon-contracts-migration branch April 26, 2024 07:51
Copy link

gitpoap-bot bot commented Apr 26, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Taiko Contributor:

GitPOAP: 2024 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants