fix(bridge-ui): dropdown css and color css fix #17000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukurenov
changed the title
KorbinianK
reviewed
May 6, 2024
KorbinianK
reviewed
May 6, 2024
packages/bridge-ui/src/components/TokenDropdown/DropdownView.svelte
Outdated
Show resolved
Hide resolved
KorbinianK
reviewed
May 6, 2024
packages/bridge-ui/src/components/TokenDropdown/DropdownView.svelte
Outdated
Show resolved
Hide resolved
KorbinianK
requested changes
May 6, 2024
packages/bridge-ui/src/components/TokenDropdown/TokenDropdown.svelte
Outdated
Show resolved
Hide resolved
KorbinianK
approved these changes
May 6, 2024
dantaik
approved these changes
May 7, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Taiko Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You use one dropdown component with two different pages, on Faucet page it not will be fixed width.
I added new boolean props isWidthFull, that you can use it from faucet component for dropdown will be 100% width
Fix example:
Before:
After:
Color fix in mobile version light style in disabled button:hover (Was been white on white) and change css cursor pointer and not-allowed(it was been in wrong place and didn't work)
I can't send hover screen, you can test it here:
Transactions page -- Select source Chain