Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(taiko-client): ontake preconfs + versioning of contracts #17907

Closed
wants to merge 113 commits into from
Closed

feat(taiko-client): ontake preconfs + versioning of contracts #17907

wants to merge 113 commits into from

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Aug 13, 2024 •
edited
Loading

  1. adds preconfirmation API support for ontake fork (code here largely unchanged vs previous)
  2. adapts taiko-client to the removal of all Legacy code
  3. versions contracts, keeping the old versions so the chain can still be synced, but uses newer versions (which lack the old functions/events) after ontake fork occurs
  4. adds preconfirmation indexer with in-memory/file DB so explorer can query API to show preconrfirmed transactions, adapts teh transactions to the Blockscout transaction standard format.

New testnet will be deployed to Helder for preconfirmation using this code + protocol code.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Aug 13, 2024 •
edited
Loading

feat(taiko-client): ontake preconfs + versioning of contracts

Generated at commit: 68cb4367e07ee3fc60c2e09a9eee718c6e45af97

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@cyberhorsey cyberhorsey changed the title feat(taiko-client): Ontake preconfs + versioning of contracts feat(taiko-client): ontake preconfs + versioning of contracts Aug 13, 2024
Base automatically changed from post_ontake_fork_cleanup2 to post_ontake_cleanup August 31, 2024 04:34
@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
taiko-mono ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 6:04pm

@cyberhorsey cyberhorsey changed the base branch from post_ontake_cleanup to main September 10, 2024 20:36
@cyberhorsey cyberhorsey changed the base branch from main to post_ontake_fork_cleanup2_client September 10, 2024 20:37
@cyberhorsey cyberhorsey closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

@YoGhurt111 YoGhurt111 Awaiting requested review from YoGhurt111

@dantaik dantaik Awaiting requested review from dantaik

Assignees
No one assigned
Labels
area.client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyberhorsey @davidtaikocha