feat(supplementary-contracts): bring over plonk verifier from raiko #17998
Conversation
feat(supplementary-contracts): bring over plonk verifier from raiko
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
|
|
||
| /// @title SP1 Verifier Interface | ||
| /// @author Succinct Labs | ||
| /// @notice This contract is the interface for the SP1 Verifier. |
There was a problem hiding this comment.
Is it possible to pnpm install the SP1 repo as a dependencies to avoid copying the code?
There was a problem hiding this comment.
There was a problem hiding this comment.
Technically we can, but this is the only file needed from that repo. All the other files are our custom - to facilitate easier devnet E2E testing AFAIK.
Not even sure if we need these in the long term. It is just an effort to bring over from raiko to taiko-mono. (Not sure if we need it here anyways! We can always deploy from that repo too when needed for devnet, since obviously for mainnet + long term devnet, the goal should be to Succinct owns it.)
There was a problem hiding this comment.
Previously we have a "third_party" folder, now it's all gone as all external file are dependencies managed by npm. I hope we don't have to bring "third_party" back.
|
Closing as according to Yue, we already support that and do not need this specific type. |
In order to have it in taiko-mono, where every contracts and deployments are, best to have it in here too.
Supplementary, because we only need it on devnet. We will not own Succinct contracts on mainnet, but this accelerates E2E testing.
source: taikoxyz/raiko#350