feat(protocol): preconfs #18089
Open
feat(protocol): preconfs #18089
+1,925
−513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): preconfs
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
dantaik
reviewed
Sep 15, 2024
| @@ -260,27 +260,25 @@ library LibProposing { | |||
|
|
|||
| // Update certain meta fields | |||
| if (meta_.blobUsed) { | |||
| if (!LibNetwork.isDencunSupported(block.chainid)) revert L1_BLOB_NOT_AVAILABLE(); | |||
| // if (!LibNetwork.isDencunSupported(block.chainid)) revert L1_BLOB_NOT_AVAILABLE(); | |||
There was a problem hiding this comment.
@cyberhorsey you don't mean to check in these changes, do you?
There was a problem hiding this comment.
Yes I do, this branch isnt made to be merged yet. This change is necessary only for the current deployment, unless we also add in the L1 chain Id of Helder to the isDencunSupported code. However Helder is not going to be very long lived, so for now I just commented this out, until we migrate to Holesky or otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on latest main