feat(bridge-ui): ERC20 Bridge + approval #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 64.57% 65.17% +0.59%
==========================================
Files 88 90 +2
Lines 2442 2484 +42
Branches 275 286 +11
==========================================
+ Hits 1577 1619 +42
Misses 793 793
Partials 72 72
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
previously approved these changes
Nov 28, 2022
Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com>
Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com>
Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com>
Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com>
davidtaikocha
previously approved these changes
Nov 30, 2022
shadab-taiko
reviewed
Dec 1, 2022
RogerLamTd
previously approved these changes
Dec 1, 2022
cyberhorsey
dismissed stale reviews from RogerLamTd and davidtaikocha
via
8d84c3d
RogerLamTd
approved these changes
Dec 1, 2022
shadab-taiko
approved these changes
Dec 1, 2022
cyberhorsey
added a commit
that referenced
this pull request
Dec 2, 2022
* feat(bridge-ui): ERC20 Bridge + approval (#353) * erc20 bridge + approve + requires allowance * bridge form checks allowance, disables button * if allowance is required, show approve button instead * set allowance required to false after successful approval * requiresallowance should take approveopts, not bridgeopts * show Approve text appropriatley * Update packages/bridge-ui/src/components/form/BridgeForm.svelte Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * Update packages/bridge-ui/src/eth/bridge.ts Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * Update packages/bridge-ui/src/components/form/BridgeForm.svelte Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * Update packages/bridge-ui/src/components/form/BridgeForm.svelte Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * inverse approve logic Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * . * lottie player * update lockfile Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com>
cyberhorsey
added a commit
that referenced
this pull request
Dec 6, 2022
* fix(bridge): wagmi init * feat(bridge): implement design * feat(bridge): add processing fee mock * fix(bridge): review fixes * feat(bridge): add default case and test * fix(bridge): update test * feat(bridge): single field bridge form * fix(bridge): processing fee * feat(bridge-ui): Transactions (#372) * feat(bridge-ui): ERC20 Bridge + approval (#353) * erc20 bridge + approve + requires allowance * bridge form checks allowance, disables button * if allowance is required, show approve button instead * set allowance required to false after successful approval * requiresallowance should take approveopts, not bridgeopts * show Approve text appropriatley * Update packages/bridge-ui/src/components/form/BridgeForm.svelte Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * Update packages/bridge-ui/src/eth/bridge.ts Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * Update packages/bridge-ui/src/components/form/BridgeForm.svelte Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * Update packages/bridge-ui/src/components/form/BridgeForm.svelte Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * inverse approve logic Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * . * lottie player * update lockfile Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> * feat: add chain selector * make ETH/TKO use ts * ignore components folder * inline block avatar * switch ethereum chain, chain navbar selection, default store values, label changing, modal * test coverage for switchEthereumChain * list * readapt bridge form to work * text * feat(bridge): switch chain modal styles * fix(bridge): chain dropdown styles * tests * rpc urls + reactive balanes * import type * cli test Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com> Co-authored-by: David <104078303+davidtaikocha@users.noreply.github.com> Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.