Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge-ui): responsive design, memo, style updates, navbar changes #396

Merged
merged 13 commits into from
Dec 9, 2022

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Dec 8, 2022

Screenshot_20221208-173613

Adds memo field to bridge form.

Fixes the non-responsive design (see atached image, or see for yourself on phone at the vercel link below).

General style updates.

Adds svelte-toast to closer match the Figma.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #396 (843e76d) into main (2d45b9c) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   65.41%   65.53%   +0.11%     
==========================================
  Files          95       96       +1     
  Lines        2585     2594       +9     
  Branches      309      310       +1     
==========================================
+ Hits         1691     1700       +9     
  Misses        827      827              
  Partials       67       67              
Flag Coverage Δ *Carryforward flag
bridge-ui 100.00% <100.00%> (ø)
protocol 59.14% <ø> (ø) Carriedforward from 2d45b9c
relayer 68.34% <ø> (ø) Carriedforward from 2d45b9c
ui 100.00% <ø> (ø) Carriedforward from 2d45b9c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ackages/bridge-ui/src/utils/switchEthereumChain.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/utils/toast.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey changed the title feat(bridge-ui): responsive design feat(bridge-ui): responsive design, memo, style updates Dec 9, 2022
@cyberhorsey cyberhorsey changed the title feat(bridge-ui): responsive design, memo, style updates feat(bridge-ui): responsive design, memo, style updates, navbar changes Dec 9, 2022
dantaik
dantaik previously approved these changes Dec 9, 2022
davidtaikocha
davidtaikocha previously approved these changes Dec 9, 2022
@cyberhorsey
Copy link
Contributor Author

Sorry Dan/David, need re-approval on this, I had one more thing (error toasts) I realized I should put in this PR! And the toggle was quite ugly for the memo!

@cyberhorsey cyberhorsey enabled auto-merge (squash) December 9, 2022 05:45
@cyberhorsey cyberhorsey merged commit 742ddcb into main Dec 9, 2022
@cyberhorsey cyberhorsey deleted the responsive branch December 9, 2022 07:25
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants