Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: using one RWLock per thread #3098

Closed
wants to merge 9 commits into from
Closed

Conversation

tusharmath
Copy link
Contributor

  • trying a new implementation for dedupe
  • add lrwlock
  • update dedupe with lrwlock
  • reset the read flag
  • use a vector instead of thread local

@tusharmath tusharmath changed the title using rw lock per thread perf: using one RWLock per thread Nov 4, 2024
@tusharmath tusharmath added the ci: benchmark Runs benchmarks label Nov 4, 2024
@github-actions github-actions bot added the type: performance Improved performance. label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

🐰 Bencher Report

Branch3098/merge
Testbedbenchmarking-runner

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_json_bench📈 view plot
⚠️ NO THRESHOLD
6,282,400.00
group_by📈 view plot
⚠️ NO THRESHOLD
486.92
input/args.missing📈 view plot
⚠️ NO THRESHOLD
22.61
input/args.nested.existing📈 view plot
⚠️ NO THRESHOLD
40.68
input/args.nested.missing📈 view plot
⚠️ NO THRESHOLD
34.43
input/args.root📈 view plot
⚠️ NO THRESHOLD
37.35
input/headers.existing📈 view plot
⚠️ NO THRESHOLD
32.62
input/headers.missing📈 view plot
⚠️ NO THRESHOLD
33.13
input/value.missing📈 view plot
⚠️ NO THRESHOLD
22.72
input/value.nested.existing📈 view plot
⚠️ NO THRESHOLD
42.47
input/value.nested.missing📈 view plot
⚠️ NO THRESHOLD
35.18
input/value.root📈 view plot
⚠️ NO THRESHOLD
37.16
input/vars.existing📈 view plot
⚠️ NO THRESHOLD
8.07
input/vars.missing📈 view plot
⚠️ NO THRESHOLD
8.54
synth_nested📈 view plot
⚠️ NO THRESHOLD
92,263.00
synth_nested_borrow📈 view plot
⚠️ NO THRESHOLD
41,007.00
test_batched_body📈 view plot
⚠️ NO THRESHOLD
1,886.20
test_batched_body #2📈 view plot
⚠️ NO THRESHOLD
1,536,200.00
test_data_loader📈 view plot
⚠️ NO THRESHOLD
389,260.00
test_handle_request📈 view plot
⚠️ NO THRESHOLD
130,380.00
test_handle_request_jit📈 view plot
⚠️ NO THRESHOLD
61,681.00
test_http_execute_method📈 view plot
⚠️ NO THRESHOLD
14,973.00
with_mustache_expressions📈 view plot
⚠️ NO THRESHOLD
1,115.90
with_mustache_literal📈 view plot
⚠️ NO THRESHOLD
691.77
🐰 View full continuous benchmarking report in Bencher

@tusharmath
Copy link
Contributor Author

Performance severely degraded.

@tusharmath tusharmath closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: performance Improved performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant