Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tailscale cert manager with tailscale-proxy command #57

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

willnorris
Copy link
Member

Instruct caddy to use the tailscale cert manager. Also add a --debug flag to enable debug logging with the tailscale-proxy command.

Also remove a lingering auto_https off config in one of our examples.

Fixes #27

@willnorris willnorris requested a review from irbekrm June 3, 2024 18:19
Instruct caddy to use the tailscale cert manager.  Also add a --debug
flag to enable debug logging with the tailscale-proxy command.

Also remove a lingering `auto_https off` config in one of our examples.

Fixes #27

Signed-off-by: Will Norris <will@tailscale.com>
@@ -216,6 +227,17 @@ func cmdTailscaleProxy(fs caddycmd.Flags) (int, error) {
},
AppsRaw: appsRaw,
}
if debug {
Copy link
Contributor

@irbekrm irbekrm Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is the caddy config generated here persisted across restarts? (If it is, then users would have no way to unset the debug flag except for by deleting the config)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this config is entirely in memory. It's not persisted anywhere.

In hindsight, I'm not actually sure how useful this tailscale-proxy subcommand really is compared to just creating a pretty simple caddyfile that does the same thing. It was something I added pretty on, mostly just to see if I could 🤷🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would the proxy subcommand be useful for the Dockerfile? #14

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, possibly. If the Dockerfile just provided a caddy binary with the tailscale plugin compiled in, then you could use that to run the proxy. I'll go ahead and add that to the v1 milestone... seems worth doing.

@willnorris willnorris merged commit 5d208f9 into main Jun 5, 2024
2 checks passed
@willnorris willnorris deleted the will/command branch June 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tailscale-proxy fails with TLS
2 participants