Add overflow: auto when using the anchor prop
#3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to constrain the anchored element within the viewport (minus the padding if there is some). But without an `overflow: auto`, it would overflow and the `maxWidth` / `maxHeight` are a bit pointless. Once you opt-in to `anchor`, then we have to provide styles anywhere. This improves the UX.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
reinink
approved these changes
Apr 25, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to constrain the anchored element within the viewport (minus the padding if there is some). But without an
overflow: auto, it would overflow and themaxWidth/maxHeightare a bit pointless.Once you opt-in to
anchor, then we have to provide styles anyway. This improves the UX.