Fix ListboxOptions being incorrectly marked as inert
#3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
ListboxOptionscomponent was incorrectly marked asinert.We only mark the other elements on the page as
inertonce theListboxis in a visible state. The issue is that thedata.optionsElement(a reference to the DOM node) was not populated with the actual DOM node yet at the time theuseInertOthers(…)hook was applied.Due to the usage of
useEvent(…), instead ofuseCallback(…)the internaluseEffect(…)hook didn't re-run because theallowedfunction was already stable.With this fix, the
allowedfunction will change whenever its dependencies change.Fixes: #3464