Fix crash when using as={Fragment} on MenuButton, ListboxButton, DisclosureButton or Button components
#3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
as={Fragment} on MenuButton, ListboxButton, DisclosureButton and Button componentsas={Fragment} on MenuButton, ListboxButton, DisclosureButton or Button components
RobinMalfait
force-pushed
the
fix/issue-3476
branch
from
ed3c6b9
to
3aa1905
Compare
philipp-spiess
approved these changes
Sep 12, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a maximum update depth exceeded error was thrown when using
as={Fragment}on button related components.The issue here is that the
refon a element would re-fire every render if the a function was used and the function is a new function (aka not a stable function).This resulted in the
refbeing called with the DOM element, thennull, then the DOM element, thennull, and so on.To solve this, we have to make sure that the
refis always a stable reference.Fixes: #3476
Fixes: #3439