Use correct ownerDocument
when using internal <Portal/>
#3594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the internal
<Portal>
component by allowing to pass in a customownerDocument
.This fixes an issue if you do something like this:
Here is a little reproduction video. The
<Menu/>
you see is rendered in an<iframe>
, the goal is that<MenuItems/>
also render inside of the<iframe>
.In the video below we start with the fix where you can see that the items are inside the iframe (and unstyled because I didn't load any styles). The second part of the video is the before, where you can see that the
<MenuItems/>
escape the<iframe>
and are styled. That's not what we want.Screen.Recording.2024-12-12.at.16.22.01.mov