-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: limit attribute rules to input and select elements #159
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Wrapping an existing portion of a selector in |
Honestly I think we should stick with the change from the original commit, where the element selector is bare but the attribute selector is wrapped in
It does reduce the specificity from |
And this is why I tagged you — I thought there was a chance you might want to. |
`input:where([type='checkbox']):checked:hover`, | ||
`input:where([type='checkbox']):checked:focus`, | ||
`input:where([type='radio']):checked:hover`, | ||
`input:where([type='radio']):checked:focus`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamwathan Should we put these pseudo classes inside :where(…)
? I'm not sure.
Currently the rules for styling the inputs are too broad and may conflict with web components that use props named type or mutiple. This PR address this issue by using :where to select only inputs without change the specificity.