-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table text alignment #346
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ah I see now, that is absolutely bizarre! 🤯 That almost seems like a browser bug but it's the same in all browsers so there must be a reason. Tweeted about it in case anyone who follows me happens to possess this arcane knowledge: https://twitter.com/adamwathan/status/1778098728601055467 I think the reason we did this on the |
Hey @adamwathan! After updating a minor version of this plugin, the table headers in HydePHP are now center aligned instead of left aligned. This was caught by our Browserstack integration. See hydephp/develop#1689 You can also view our public Browserstack page where this was caught https://percy.io/9d5269d1/hydephp/builds/33912142/changed/1856671999 |
I can confirm that @lopez-marc's proposed changes work as intended. Here is their patch applied to the HydePHP testing fixture: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are confirmed to have fixed this problem in HydePHP.
@lopez-marc Hey thanks for this fix! 🙏 |
@reinink Happy to contribute! |
This reverts commit 0f8d7e4 as the bug is fixed downstream.
After this commit, text alignment in tables no longer works as intended. It appears that
text-align: start;
does not apply correctly to thetable
tag.To address this, I propose applying
text-align: start;
directly to theth
andtd
tags, ensuring correct alignment.