Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort arbitrary variants deterministically regardless of content order #10016

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Sort arbitrary variants deterministically regardless of content order #10016

merged 5 commits into from
Dec 8, 2022
+214 −14

Commits on Dec 8, 2022

  1. Fix off-by-one error in variant sort mapping 

    This didn’t actually have any negative effect because of how it was implemented. But it only happened to work right :D
    @thecrypticace
    thecrypticace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    12dac7d View commit details
    Browse the repository at this point in the history

  2. Make arbitrary variant sorting deterministic

    @thecrypticace
    thecrypticace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    450956e View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @thecrypticace
    thecrypticace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    89da23f View commit details
    Browse the repository at this point in the history

  4. Use faster byte-order comparison 

    We really only care that the order is _always_ the same. localeCompare is still locale dependent based on environment. This ensures it’s dependent on content only.
    @thecrypticace
    thecrypticace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    9fbe79a View commit details
    Browse the repository at this point in the history

  5. Fix CS

    @thecrypticace
    thecrypticace committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    872f047 View commit details
    Browse the repository at this point in the history