Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't prefix arbitrary classes in peer/group variants #11454

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Don't prefix arbitrary classes in peer/group variants #11454

merged 5 commits into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. Refactor

    @thecrypticace
    thecrypticace committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    988f29b View commit details
    Browse the repository at this point in the history

  2. Don’t prefix classes in arbitrary values for group and peer

    @thecrypticace
    thecrypticace committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1b651fc View commit details
    Browse the repository at this point in the history

  3. use foo instead of lol

    @RobinMalfait
    RobinMalfait committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8e2a3df View commit details
    Browse the repository at this point in the history

  4. handle the prefix inside the group/peer variants 

    Then add the `NoPrefix` feature to the variant itself, which will skip
prefixing any other class in the generated selector (because we already
took care of prefixing `.group` and `.peer`).

We are using an internal symbol such that:

- We can keep it as a private API
- We don't introduce a breaking change
    @RobinMalfait
    RobinMalfait committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    504fd19 View commit details
    Browse the repository at this point in the history

  5. refactor to simple object instead 

    We will still use a symbol as an internal/private marker, but the data
itself will be a simple object for now.

If we want to refactor this (and more) in the future using bitflags then
we can refactor that in a separate PR.
    @RobinMalfait
    RobinMalfait committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    214794a View commit details
    Browse the repository at this point in the history