-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid over-extracting utilities from candidates with decimal values #13959
Merged
adamwathan
merged 2 commits into
master
from
avoid-overextracting-from-decimal-utilities
Jul 5, 2024
Merged
Avoid over-extracting utilities from candidates with decimal values #13959
adamwathan
merged 2 commits into
master
from
avoid-overextracting-from-decimal-utilities
Jul 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent candidates like `px-1.5` from generating both the `px-1.5` class and the `px-1` class.
RobinMalfait
approved these changes
Jul 5, 2024
@adamwathan all Angular Apps are broken with this PR, would be great if this could be fixed soon. |
This was referenced Aug 7, 2024
This was referenced Sep 1, 2024
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents candidates like
px-1.5
from generating both thepx-1.5
class and thepx-1
class.There's a chance that the inner matches regex we're throwing away here handles some other cases that aren't currently tested, but since they aren't tested I'm assuming it's not needed. We'll find out quickly from our users if they were and can fix it then :)
Fixes #13952 and #9354 and probably a bunch of other issues that have been opened for the same thing.