Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to latest cssnano v6 #14105

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Bump to latest cssnano v6 #14105

merged 3 commits into from
Aug 2, 2024
+479 −404

Conversation

thecrypticace
Copy link
Contributor

We bundle cssnano in our CLI and it's on an older version that does not handle nested CSS correctly. This PR updates it to the latest version of v6.x

Fixes #14092

RobinMalfait
RobinMalfait approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do we want to add a changelog entry for this? If so, I think we should mention the bug it fixed instead of what we did.

Fix minification when using nested CSS

Or something like that.

@thecrypticace thecrypticace merged commit 1f23c2e into master Aug 2, 2024
13 checks passed
@thecrypticace thecrypticace deleted the fix/v3-bump-cssnano branch August 2, 2024 12:57
@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2024
Merged
@mightysai1997 mightysai1997 mentioned this pull request Aug 28, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 29, 2024
Merged
@zntb zntb mentioned this pull request Aug 29, 2024
Merged
@randomusert randomusert mentioned this pull request Aug 29, 2024
Closed
@neutron-robot neutron-robot mentioned this pull request Aug 29, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 29, 2024
Open
@zdr4k zdr4k mentioned this pull request Aug 29, 2024
Open
@spudly spudly mentioned this pull request Aug 29, 2024
Merged
@leroyanders leroyanders mentioned this pull request Aug 29, 2024
Open
@bamanczak bamanczak mentioned this pull request Aug 29, 2024
Merged
@zntb zntb mentioned this pull request Aug 30, 2024
Merged
@LLotme LLotme mentioned this pull request Aug 30, 2024
Merged
@abuzar0013 abuzar0013 mentioned this pull request Aug 30, 2024
Open
@zdr4k zdr4k mentioned this pull request Aug 30, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Aug 30, 2024
Merged
@spudly spudly mentioned this pull request Aug 30, 2024
Merged
@carltrepanier carltrepanier mentioned this pull request Aug 30, 2024
Merged
@cx48 cx48 mentioned this pull request Aug 30, 2024
Merged
@bamanczak bamanczak mentioned this pull request Aug 30, 2024
Closed
@leroyanders leroyanders mentioned this pull request Aug 30, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 30, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 31, 2024
Open
This was referenced Sep 1, 2024
Open
Open
@AressAntonio AressAntonio mentioned this pull request Sep 2, 2024
Open
@leroyanders leroyanders mentioned this pull request Sep 3, 2024
Open
@zdr4k zdr4k mentioned this pull request Sep 4, 2024
Open
@leroyanders leroyanders mentioned this pull request Sep 4, 2024
Open
@abanoubtalaatr abanoubtalaatr mentioned this pull request Sep 4, 2024
Open
@fajllo fajllo mentioned this pull request Sep 4, 2024
Open
@MinhazAyaaz MinhazAyaaz mentioned this pull request Sep 5, 2024
Open
@leroyanders leroyanders mentioned this pull request Sep 5, 2024
Open
@bamanczak bamanczak mentioned this pull request Sep 6, 2024
Merged
@snyk-studygroup snyk-studygroup mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 7, 2024
Open
Open
Open
Open
@leroyanders leroyanders mentioned this pull request Sep 15, 2024
Open
@randomusert randomusert mentioned this pull request Sep 16, 2024
Open
@XavierMP14 XavierMP14 mentioned this pull request Sep 17, 2024
Open
@leroyanders leroyanders mentioned this pull request Sep 17, 2024
Open
@GabsBaquie GabsBaquie mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
@RAHUL1115 RAHUL1115 mentioned this pull request Sep 22, 2024
Open
@AndresElacion AndresElacion mentioned this pull request Sep 22, 2024
Open
@leroyanders leroyanders mentioned this pull request Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinMalfait RobinMalfait RobinMalfait approved these changes

@adamwathan adamwathan adamwathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thecrypticace @RobinMalfait @adamwathan