Fix v4 release workflow #14167
Merged
Fix v4 release workflow #14167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to keep the `pnpm run build` an alias for `turbo`. Passing any flags to the `pnpm run build` command will correctly format it to the `turbo build` step.
RobinMalfait
force-pushed
the
fix/always-setup-rustup-stable
branch
from
04fdd18
to
2141668
Compare
This way the flags are passed to `pnpm` itself instead of the underlying command.
None of the items in the matrix have a `setup` step. We can just drop this now.
RobinMalfait
force-pushed
the
fix/always-setup-rustup-stable
branch
from
2141668
to
4492713
Compare
This reverts commit 4492713.
philipp-spiess
approved these changes
Aug 9, 2024
thecrypticace
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the release workflow
pnpm run buildcommand are forwarded to the underlying command.pnpmspecific flags before the actual command