Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CI to run jobs in parallel #14476

Conversation

n-batalha
Copy link

@n-batalha n-batalha commented Sep 20, 2024

I shaved some minutes from the CI (In the scenario of caches being hit, the most common?) by splitting various test types into their own jobs, to run them in parallel.
So it's as fast as its slowest job (Windows integration tests), rather than unrelated tests waiting on others.

I guess the DX improves too, to more quickly visualise failing tests on the job list (instead of needing to open a job to look for the failing step).

Before:

image

After (sometimes 6min, not sure why the large variance):

image

(Edit: apologies, I created duplicate PRs because it seems I can't force push and reopen #14460)

@n-batalha n-batalha closed this Sep 20, 2024
@n-batalha n-batalha deleted the vitest-integration-test-ci-improvement branch September 20, 2024 08:22
@n-batalha n-batalha restored the vitest-integration-test-ci-improvement branch September 20, 2024 09:08
@n-batalha n-batalha reopened this Sep 20, 2024
@n-batalha
Copy link
Author

n-batalha commented Sep 20, 2024

Now that the workflow is finally running, I see that the Windows job is running slower here than in my repo (with the same workflow). You have more actions running in parallel from other branches, whereas I only had my own workflow running, so perhaps there is a runner bottleneck too.
Mine:

image

https://github.com/n-batalha/tailwindcss/actions/runs/10955846499/job/30422079568?pr=2

Yours:
image

https://github.com/tailwindlabs/tailwindcss/actions/runs/10956650806/job/30438139771?pr=14476

See Docs for larger runners

@n-batalha
Copy link
Author

Discussing separately, the team improved the Windows jobs (the slowest) and might prefer it serially, closing for now

@n-batalha n-batalha closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant