Fix matchVariants that use at-rules and placeholders #8392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, using the new
matchVariant
API with super complex format strings like@media (pointer: whatever) { &:blah }
didn't work, because we had duplicated some logic but missed some edge cases.This PR unifies the logic for parsing variant format strings so that anything that works with
addVariant
is guaranteed to work withmatchVariant
or arbitrary variants, or anything else.