-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow returning parallel variants from addVariant
or matchVariant
callback functions
#8455
Merged
RobinMalfait
merged 9 commits into
master
from
fix/allow-variant-format-strings-from-function
May 31, 2022
Merged
Allow returning parallel variants from addVariant
or matchVariant
callback functions
#8455
RobinMalfait
merged 9 commits into
master
from
fix/allow-variant-format-strings-from-function
May 31, 2022
Commits on May 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9824a79 - Browse repository at this point
Copy the full SHA 9824a79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b15caa - Browse repository at this point
Copy the full SHA 6b15caaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5369ca - Browse repository at this point
Copy the full SHA f5369caView commit details -
allow to return parallel variants from variant function
Caveat: this now belongs to the same plugin and is not registered as separate variants which means that sort order can differ.
Configuration menu - View commit details
-
Copy full SHA for e1006f8 - Browse repository at this point
Copy the full SHA e1006f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f94311b - Browse repository at this point
Copy the full SHA f94311bView commit details -
Configuration menu - View commit details
-
Copy full SHA for be09acc - Browse repository at this point
Copy the full SHA be09accView commit details -
ensure that we use a local list of variant functions
Now that a variant function can return a list of variant functions from within the plugin, we have to make sure to executed and register those functions as well. However, we need to make sure that this list is local for the variant and not "globally" registered otherwise we keep add a dynamic function to the global list which results in duplicate output becaus multiple duplicate variants will be registered.
Configuration menu - View commit details
-
Copy full SHA for fbeaca8 - Browse repository at this point
Copy the full SHA fbeaca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dae24b7 - Browse repository at this point
Copy the full SHA dae24b7View commit details
Commits on May 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 641400a - Browse repository at this point
Copy the full SHA 641400aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.