Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable postcss-import in the CLI by default in watch mode #8574

Closed
wants to merge 5 commits into from
Closed

Enable postcss-import in the CLI by default in watch mode #8574

wants to merge 5 commits into from

Conversation

adambrgmn
Copy link
Contributor

@adambrgmn adambrgmn commented Jun 10, 2022

PR #8437 added support for postcss-import by default in tailwind-css cli. But watch mode was forgotten. This PR adds postcss-import as a built-in plugin in both watch mode and regular build mode.

Changes:

  • Add support for postcss-import in watch mode
  • Add regression test
  • Extract shared logic

Thanks for a great project! ❤️ Hope it's okey that I went straight ahead and submitted a PR before opening an issue. Let me know if you want me to close and go that route instead.

@RobinMalfait RobinMalfait self-assigned this Jun 10, 2022
Instead of relying on a arbitrary setTimout value, let's wait for the
file to be created instead.
@RobinMalfait RobinMalfait changed the title Enable postcss-import by default in watch mode Enable postcss-import in the CLI by default in watch mode Jun 10, 2022
@RobinMalfait
Copy link
Member

Hey! Thank you for your PR!
Much appreciated! 🙏

I created a new PR #8580 and started from your PR but made a few small changes and rebased onto the master branch. Since I started from your branch, you are still marked as a contributor 💪

@adambrgmn
Copy link
Contributor Author

Thank you @RobinMalfait 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants