Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cannot read properties of undefined (reading 'modifier') #9656

Merged
merged 5 commits into from
Nov 3, 2022
Merged

Fix cannot read properties of undefined (reading 'modifier') #9656

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0c4aa9
fix #9655
ttkoma Oct 25, 2022
17de0c3
Merge branch 'master' into fix-addVariant
RobinMalfait Nov 3, 2022
229f32d
update changelog
RobinMalfait Nov 3, 2022
5fd1ad1
add test for making sure calling variantFn doesn't crash
RobinMalfait Nov 3, 2022
5626fe6
make it behave as-if modifiers didn't exist
RobinMalfait Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lib/setupContextUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ function buildPluginApi(tailwindConfig, context, { variantList, variantMap, offs
({ args, container }) =>
variantFn(
value,
modifiersEnabled ? { modifier: args.modifier, container } : { container }
modifiersEnabled ? { modifier: (args ?? {}).modifier, container } : { container }
),
{
...options,
Expand All @@ -601,6 +601,10 @@ function buildPluginApi(tailwindConfig, context, { variantList, variantMap, offs
api.addVariant(
variant,
({ args, container }) => {
if (!args) {
return null
}

if (args.value === sharedState.NONE && !hasDefault) {
Copy link

@theskollie theskollie Oct 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if (!args ||  args.value === sharedState.NONE && !hasDefault) {
return null;
}

return null
}
Expand Down