Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for excss.config.ts #35

Merged
merged 15 commits into from
Sep 13, 2023
Merged

feat: support for excss.config.ts #35

merged 15 commits into from
Sep 13, 2023

Conversation

taishinaritomi
Copy link
Owner

@taishinaritomi taishinaritomi commented Sep 7, 2023

In this PR, we are relocating the excess configuration settings from vite.config.ts and other similar files to a newly created excss.config.ts. This step is crucial as we gear up for the creation of a future VSCode extension, where the extension needs the ability to read the configuration seamlessly. Additionally, this modification will streamline the process of switching between bundlers whenever necessary, making it more efficient.

vite.config.ts

In the updated configuration, we have simplified the excss plugin initialization in vite.config.ts. Similar changes are also implemented in Next.js and webpack.

import Excss from "excss/vite";
import { defineConfig } from "vite";

export default defineConfig({
  plugins: [
+    Excss(),
-    Excss({
-      inject: ``,
-    }),
  ],
});

excss.config.ts

A new file excss.config.ts has been introduced to house the excess configuration settings, which includes the inject option.

+import { defineConfig } from "excss/config";
+
+export default defineConfig({
+  inject: ``,
+});

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 0dc22af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
excss Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taishinaritomi taishinaritomi merged commit 8953f56 into main Sep 13, 2023
1 check passed
@taishinaritomi taishinaritomi deleted the excss-config branch September 13, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant