Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not clone the session when using maven >= 3.9.x #24

Closed
gnodet opened this issue May 9, 2023 · 6 comments
Closed

Do not clone the session when using maven >= 3.9.x #24

gnodet opened this issue May 9, 2023 · 6 comments

Comments

@gnodet
Copy link
Member

gnodet commented May 9, 2023

See apache/maven-mvnd#841 (comment)
@gnodet
Copy link
Member Author

gnodet commented May 10, 2023

Not an issue with the builder.

@gnodet gnodet closed this as completed May 10, 2023
@gnodet
Copy link
Member Author

gnodet commented May 10, 2023

This is actually an issue in the builder.

@gnodet gnodet reopened this May 10, 2023
@gnodet gnodet changed the title Module name not set correctly Do not clone the session when using maven >= 3.9.x May 10, 2023
gnodet added a commit to gnodet/takari-smart-builder that referenced this issue May 10, 2023
@gnodet
Do not clone the session on maven >= 3.9.x, fixes takari#24
9ced72c
gnodet added a commit to gnodet/takari-smart-builder that referenced this issue May 10, 2023
@gnodet
Do not clone the session on maven >= 3.9.x, fixes takari#24
d84a987
@ppalaga
Copy link

ppalaga commented May 10, 2023

Why does Maven 3.9.0+ make a difference?

@cstamas
Copy link
Member

cstamas commented May 10, 2023

mvnd by default uses smart builder, while 3.9.x does not (only if configured as extension). That would be an interesting case to test: 3.9.x w/ smart builder extension and builder config to use it actually.

@cstamas
Copy link
Member

cstamas commented May 11, 2023

@gnodet ...or did I miss the point? I just now see that I misinterpreted @ppalaga question.... So yes, why does Maven 3.9.0+ makes a difference?

@gnodet gnodet closed this as completed in ed916da May 11, 2023
@gnodet
Copy link
Member Author

gnodet commented May 14, 2023

@gnodet ...or did I miss the point? I just now see that I misinterpreted @ppalaga question.... So yes, why does Maven 3.9.0+ makes a difference?

Because the session cloning has been removed in 3.9.x with apache/maven#743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cstamas @gnodet @ppalaga