Getting ride of guava #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifedorenko
requested changes
Oct 31, 2018
There was a problem hiding this comment.
I am generally in favour of this change, but I'd like to see few changes before I merge it. You will also need to submit signed CLA to takari.
| @@ -38,7 +36,7 @@ | |||
|
|
|||
| public static Comparator<MavenProject> create(MavenSession session) { | |||
| final ProjectDependencyGraph dependencyGraph = session.getProjectDependencyGraph(); | |||
| return create0(DependencyGraph.fromMaven(dependencyGraph), ImmutableMap.of(), p -> id(p)); | |||
| return create0(DependencyGraph.fromMaven(dependencyGraph), new HashMap<>(), p -> id(p)); | |||
There was a problem hiding this comment.
I think emptyMap is more appropriate here
| this.rootProjects = ImmutableSet.copyOf(rootProjects); | ||
| this.projects = ImmutableSet.copyOf(projects); | ||
| this.rootProjects = new HashSet<>(rootProjects); | ||
| this.projects = new HashSet<>(projects); |
There was a problem hiding this comment.
We need immutable ordered sets here.
| this.serviceTimes = ImmutableMap.copyOf(serviceTimes); | ||
| this.bottleneckTimes = ImmutableMap.copyOf(bottleneckTimes); | ||
| this.serviceTimes = new HashMap<>(serviceTimes); | ||
| this.bottleneckTimes = new HashMap<>(bottleneckTimes); |
There was a problem hiding this comment.
We need immutable maps here, and I'd make them ordered just for consistency.
| ImmutableMap.Builder<String, AtomicLong> serviceTimes = ImmutableMap.builder(); | ||
| ImmutableMap.Builder<String, AtomicLong> bottleneckTimes = ImmutableMap.builder(); | ||
| Map<String, AtomicLong> serviceTimes = new HashMap<>(); | ||
| Map<String, AtomicLong> bottleneckTimes = new HashMap<>(); |
There was a problem hiding this comment.
We need immutable maps here, and I'd make them ordered just for consistency.
velo
force-pushed
the
master
branch
2 times, most recently
from
cf9401d to
0bed705
Compare
|
Changes applied and CLA sent |
|
@velo Happy Birthday! |
|
Superseded with #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got class def not found when running with maven 3.5.4
Since it was not critical, I decided to take it away