Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/select chips behaviour #719

Open
wants to merge 3 commits into
base: developer
Choose a base branch
from

Conversation

andrewcs0901
Copy link

Fix Select Chips Behavior

This pull request aims to address some issues with the select chips component, such as:

  • Moved the focus on the “element_input” div to input element, which was preventing text selection on the chip
  • Fixed the select toggling with every click inside the component
  • Fixed a bug where select options would not render when an added item was duplicated
    • Reproduction steps:
      • Add an item, for example: “abc”
      • Add the same item again, “abc” (via click on option or Enter key)
      • Click on the input
      • The select options no longer appear
  • Refactored to use handler function thats add new options via click and the Enter key, removing duplicated code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant