Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #316

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Fix typo #316

merged 4 commits into from
Aug 9, 2023

Conversation

asmith26
Copy link
Contributor

@asmith26 asmith26 commented Aug 8, 2023

Hi, I noticed a typo that I've fixed. I also felt it might be better to use This metric over This metrics (but feel free to revert this :))

Many thanks for this amazing lib!

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #316 (3e42aa6) into master (fc739c7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files         107      107           
  Lines        7106     7106           
=======================================
  Hits         6587     6587           
  Misses        519      519           
Files Changed Coverage Δ
d3rlpy/metrics/evaluators.py 97.15% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@asmith26 asmith26 marked this pull request as draft August 8, 2023 21:57
@asmith26 asmith26 marked this pull request as ready for review August 8, 2023 21:57
@takuseno
Copy link
Owner

takuseno commented Aug 9, 2023

@asmith26 LGTM. Thank you for your contribution!

@takuseno takuseno merged commit adca5f4 into takuseno:master Aug 9, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants