-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds rpccookie to bitcoind auth methods #249
Conversation
c42da84
to
410d45d
Compare
work as expected I will provide details of the test comment below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change looks fine, I tested and work as expected details #246 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, seems to work for me. Just thought I'd suggest to keep the conf template up to date, maybe with a comment in the # bitcoind
section that only one auth method is allowed. https://github.com/talaia-labs/rust-teos/blob/master/teos/src/conf_template.toml
Also the lint error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some few comments inline.
410d45d
to
8377217
Compare
Addresses review comments from @orbitalturtle and @mariocynicys |
8377217
to
726c4fa
Compare
726c4fa
to
900c746
Compare
Currently we are authenticating against bitcoind using user/pass. This adds the option to use a cookie file instead.
900c746
to
37a75ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently, we are authenticating against bitcoind using user/pass. This adds the option to use a cookie file instead.
Notice providing the two authentication methods at the same time is not permitted, users must set either the user/pass pair or the cookie file path.
Close #246