Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(to issue#455): fix a typo #456

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

elephas00
Copy link
Contributor

I am recently debugging at 3B. And when I am reading the Destroy function at file kv/raftstore/peer.go, I found that there is a comment "write kv rocksdb first in case of restart happen between two write". The previous lab in tinykv seems never mention about rocksdb, while the TiKV mentioned. So I think there is a typo, and this comment should be modified to "write kv badgerDB first in case of restart happen between two write".

I am recently debugging at 3B. And when I am reading the Destroy function at file kv/raftstore/peer.go, I found that there is a comment "write kv rocksdb first in case of restart happen between two write".
The previous lab in tinykv seems never mention about rocksdb, while the TiKV mentioned. So I think there is a typo, and this comment should be modified to "write kv badgerDB first in case of restart happen between two write".
Copy link
Collaborator

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Connor1996 Connor1996 enabled auto-merge (squash) March 15, 2024 02:03
@Connor1996 Connor1996 merged commit 1338f1b into talent-plan:course Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants