perf(auth): avoid unnecessary token refresh on get_project() #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheKevJames
requested review from
cphoward,
jonathan-johnston and
shaundialpad
and removed request for
a team
cphoward
approved these changes
Nov 15, 2023
jonathan-johnston
added a commit
that referenced
this pull request
Dec 7, 2023
* Pull in perf change to next auth release: #653 * Fix `ssl` flag for `gcloud-aio-auth` * Fix flaky BQ integration tests with `backoff`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Perf optimization: for GCE_METADATA tokens, there's no hit the token refresh
endpoint when we're only looking to call
get_project()and have the value setlocally.