Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.apache.logging.log4j:log4j-api from 2.23.1 to 2.24.1 #491

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 30, 2024

Bumps org.apache.logging.log4j:log4j-api from 2.23.1 to 2.24.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps org.apache.logging.log4j:log4j-api from 2.23.1 to 2.24.1.

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@sjoerdtalsma
Copy link
Contributor

@Marcono1234 It seems the fix for apache/logging-log4j2#2946 doesn't fix our tests, could you please take a look?

Error:  Tests run: 18, Failures: 9, Errors: 0, Skipped: 0

@Marcono1234
Copy link
Contributor

It looks like that Log4j 2 issue was not fully fixed, see apache/logging-log4j2#2946 (comment) (and subsequent comments and linked pull request).

Would it be ok for you to again wait for the next Log4j 2 release? I hope this dependency update here is not urgent.

@sjoerdtalsma
Copy link
Contributor

sjoerdtalsma commented Oct 7, 2024 via email

@sjoerdtalsma
Copy link
Contributor

Skip this version and wait for the next patch version.

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 7, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/org.apache.logging.log4j-log4j-api-2.24.1 branch October 7, 2024 07:00
@Marcono1234
Copy link
Contributor

It seems this was unrelated to the above mentioned Log4j 2 issue, and can already be fixed: #498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants