Release/v1.3.0

[rohansharmasitoula]

Description

• Master Merge

Github Issue

• Launch Exam on TSB if TSB enabled #36

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires only a documentation update

Dependencies (if any):

• fixed-tsb-not-loading-for-pw moodle-local_proview#74

Summary by CodeRabbit

• New Features

  • Introduced new methods to enhance quiz access control.

• Refactor

  • Improved code formatting for better readability and maintenance.

• Documentation

  • Updated versioning information to reflect the latest release.

[coderabbitai]

Walkthrough

The PHP class quizaccess_proctor has been updated with improved formatting, type declarations, and the addition of new methods enhancing its functionality. Additionally, the plugin's version and release information have been incremented to reflect these updates and new features.

Changes

File(s)	Summary of Changes
rule.php	Added curly braces to class declaration, formatted constructor and static methods, updated method signatures with type declarations, and introduced new methods is_tsb_required and redirect_to_tsb_link.
version.php	Updated the $plugin object's version and release properties to new values.

🐇✨
In the code where we hop and dwell,
Braces and types we align so well.
New methods born, a version new,
A rabbit's touch, in lines so few. 🌟📜

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7e8570a and 2acbb69.

Files selected for processing (2)

• rule.php (10 hunks)
• version.php (1 hunks)

Additional comments: 12

rule.php (10)

• 39-46:
  The addition of the opening curly brace {} for the class declaration is a formatting change and does not affect functionality.

• 52-58:
  The constructor now includes type declarations for its parameters, which enforces type safety and is a significant change.

• 71-74:
  The static method make should also include type declarations for its parameters to maintain consistency with the constructor's new type declarations.

- public static function make(quiz $quizobj, $timenow, $canignoretimelimits)
+ public static function make(quiz $quizobj, int $timenow, bool $canignoretimelimits)

• 82-88:
  The addition of the static method add_settings_form_fields introduces new functionality related to quiz settings.

• 97-110:
  The method validate_settings_form_fields now includes type declarations for its parameters and a return type, which enforces type safety and is a significant change.

• 136-143:
  The static method save_settings should include type declarations for its parameter to maintain consistency with the other updated methods.

- public static function save_settings($quiz)
+ public static function save_settings(object $quiz)

• 173-179:
  The save_settings method includes logic to handle the saving of proctor settings, which is part of the new functionality.

• 192-199:
  The static method delete_settings should include type declarations for its parameter to maintain consistency with the other updated methods.

- public static function delete_settings($quiz)
+ public static function delete_settings(object $quiz)

• 221-228:
  The method get_settings_sql now includes a return type declaration, which enforces type safety and is a significant change.

• 237-290:
  The addition of new methods is_tsb_required and redirect_to_tsb_link introduces new functionalities related to test security buffer (TSB).

version.php (2)

• 28-30: The updates to the $plugin->version and $plugin->release properties are consistent with the PR objectives and the summary provided. These changes correctly reflect a new version release.

• 25-33: Ensure that the dependency on pull request #74 in the talview/moodle-local_proview repository is resolved before merging this pull request, as it may contain related changes that are necessary for this version release.

[devang1281]

LGTM